Conversation
Some client-proxy tests set HTTP_PROXY variable in the environment. It's OK in general, however, in some specific cases, the user might have already defined his own http_proxy setting in the environment. The lowercase user setting takes precedence and leads to a test failure. The fix cleans up the environment to avoid an interaction between user and test proxy settings.
toUpper() -> toUpperCase()
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61473 +/- ##
==========================================
- Coverage 89.87% 89.85% -0.02%
==========================================
Files 671 671
Lines 203178 203182 +4
Branches 39062 39066 +4
==========================================
- Hits 182599 182563 -36
- Misses 12926 12964 +38
- Partials 7653 7655 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test fails behind a proxy
Running tests behind proxy fails when http_proxy and https_proxy variables are defined in the user environment.
Please see below relevant snippets of the output of
make -j2 test.This is on Linux.