watch: re-expose watch flags via execArgv#60665
Open
Han5991 wants to merge 4 commits intonodejs:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60665 +/- ##
==========================================
+ Coverage 88.03% 88.53% +0.50%
==========================================
Files 703 703
Lines 208257 208273 +16
Branches 40069 40150 +81
==========================================
+ Hits 183336 184402 +1066
+ Misses 16883 15880 -1003
+ Partials 8038 7991 -47
🚀 New features to boost your workflow:
|
b228a4a to
3e2a96f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60594
Summary
--watch*flags and pass them to the child throughNODE_WATCH_ARGS.NODE_WATCH_ARGS, prepend the recovered flags toprocess.execArgv, and delete the env var.test/sequential/test-watch-mode-watch-flags.mjsto assert that watch flags show up at the beginning ofprocess.execArgv, accepting both--watch-path valueand--watch-path=valueforms.Testing