-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
build: test on Python 3.14 #59983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: test on Python 3.14 #59983
Conversation
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
ba01e24 to
97f2670
Compare
97f2670 to
40575dc
Compare
40575dc to
109d743
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59983 +/- ##
==========================================
- Coverage 88.46% 88.45% -0.01%
==========================================
Files 703 703
Lines 207368 207368
Branches 39983 39980 -3
==========================================
- Hits 183438 183427 -11
+ Misses 15933 15931 -2
- Partials 7997 8010 +13 🚀 New features to boost your workflow:
|
|
Python 3.14 (the π version) was released today. |
| uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
| allow-prereleases: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we dont need this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually just leave them in place so we can test Python 3.15, etc.
marco-ippolito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a green CI
|
Landed in 8bc7dfd |
Node 25 is tested with Python 3.14! Refs: nodejs/node#59983 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
SQUASHED UPSTREAM COMMITS: tools: make nodedownload module compatible with Python 3.14 FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14. Fixes: nodejs#58740 PR-URL: nodejs#58752 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> build: test on Python 3.14 release candidate 3 Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
SQUASHED UPSTREAM COMMITS: build: test on Python 3.14 release candidate 3 Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: nodejs#59983 Backport-PR-URL: nodejs#61370 Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Refs: nodejs#60874
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: #59983 Backport-PR-URL: #61370 Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Refs: #60874
Python v3.14 -- October 7th * https://www.python.org/download/pre-releases * https://www.python.org/downloads/release/python-3140rc3 PR-URL: #59983 Backport-PR-URL: #61370 Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Refs: #60874
Notable changes: build: * add support for Python 3.14 (Christian Clauss) #59983 cli: * mark `--heapsnapshot-near-heap-limit` as stable (Joyee Cheung) #60956 crypto: * update root certificates to NSS 3.119 (Node.js GitHub Bot) #61419 doc: * mark `--build-snapshot` and `--build-snapshot-config` as stable (Joyee Cheung) #60954 meta: * add avivkeller to collaborators (Aviv Keller) #61115 * add gurgunday to collaborators (Gürgün Dayıoğlu) #61094 * add Renegade334 to collaborators (Renegade334) #60714 url: * update ada to v3.4.2 and support unicode 17 (Yagiz Nizipli) #61593 v8: * mark `v8.queryObjects()` as stable (Joyee Cheung) #60957 PR-URL: #61661
Notable changes: build: * add support for Python 3.14 (Christian Clauss) #59983 cli: * mark `--heapsnapshot-near-heap-limit` as stable (Joyee Cheung) #60956 crypto: * update root certificates to NSS 3.119 (Node.js GitHub Bot) #61419 doc: * mark `--build-snapshot` and `--build-snapshot-config` as stable (Joyee Cheung) #60954 meta: * add avivkeller to collaborators (Aviv Keller) #61115 * add gurgunday to collaborators (Gürgün Dayıoğlu) #61094 * add Renegade334 to collaborators (Renegade334) #60714 url: * update ada to v3.4.2 and support unicode 17 (Yagiz Nizipli) #61593 v8: * mark `v8.queryObjects()` as stable (Joyee Cheung) #60957 PR-URL: #61661
Python v3.14 -- October 7th