Conversation
Increase timeout on Raspberry Pi to alleviate flakiness. Fixes: nodejs#5854
|
Stress test that will hopefully show flakiness on master: https://ci.nodejs.org/job/node-stress-single-test/564/nodes=pi1-raspbian-wheezy/console Stress test that will hopefully show no flakiness with this change: https://ci.nodejs.org/job/node-stress-single-test/565/nodes=pi1-raspbian-wheezy/console (They've both been compiling for 2.5 hours...pi1 platform, whatcha gonna do, rite?) |
|
LGTM |
1 similar comment
|
LGTM |
|
100 runs did not seem to be enough to get a flaky result on master. Trying 999. master: https://ci.nodejs.org/job/node-stress-single-test/566/nodes=pi1-raspbian-wheezy/console this branch: https://ci.nodejs.org/job/node-stress-single-test/567/nodes=pi1-raspbian-wheezy/console |
|
Stress test at 999 jobs still does not reproduce issue on master, but we have the one example and this would seem to be an improvement, so... |
Increase timeout on Raspberry Pi to alleviate flakiness. Fixes: nodejs#5854 PR-URL: nodejs#5856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 04ac1c0 |
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test
Description of change
Increase timeout on Raspberry Pi to alleviate flakiness.
Fixes: #5854