esm: optimize string checks and slicing with direct index access#55435
Closed
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Closed
esm: optimize string checks and slicing with direct index access#55435mertcanaltin wants to merge 2 commits intonodejs:mainfrom
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
ljharb
reviewed
Oct 17, 2024
ljharb
approved these changes
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55435 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 653 653
Lines 187604 187602 -2
Branches 36119 36114 -5
==========================================
- Hits 165849 165843 -6
+ Misses 14983 14977 -6
- Partials 6772 6782 +10
|
lpinca
approved these changes
Oct 18, 2024
legendecas
reviewed
Oct 18, 2024
Member
legendecas
left a comment
There was a problem hiding this comment.
This is also done in #55407.
Member
Author
I'm closing this thank you very much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize string manipulation by replacing prototype methods with direct index access for improved performance.