Closed
Conversation
avivkeller
reviewed
Aug 30, 2024
Comment on lines
+1202
to
+1214
| ## Web Storage API | ||
|
|
||
| In Node.js, the localStorage and sessionStorage objects function differently compared to browsers or Deno: | ||
|
|
||
| * Both `localStorage` and `sessionStorage` are scoped to the current process, | ||
| not individual users or server requests. This is crucial for applications | ||
| like server-side rendering. | ||
| * `localStorage` uses the value of the `--localstorage-file` flag as its | ||
| origin. This file can be accessed simultaneously by multiple processes, | ||
| which may require implementing file locking or other synchronization | ||
| mechanisms to ensure data integrity. | ||
| * The storage quota for both `localStorage` and `sessionStorage` is | ||
| 10MB per process. |
Member
There was a problem hiding this comment.
I think this information is already present in this file under localStorage and sessionStorage
| done | ||
| ``` | ||
|
|
||
| ### --localstorage-file |
Member
There was a problem hiding this comment.
I think this entry already exists somewhere else in the file.
Member
|
Possible duplicate of #53881 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
doc: clarify Web Storage behavior and document --localstorage-file optionDescription:
Issue Resolved
This pull request addresses the issue outlined in #53871. The changes clarify the Web Storage behavior in Node.js and document the
--localstorage-fileoption.Changes Made
cli.md: Added documentation for the--localstorage-fileoption.--max-old-space-sizesection.--localstorage-fileoption to specify the file used forlocalStoragein Node.js.Example documentation snippet added:
globals.md: Added a new section describing howlocalStorageandsessionStoragebehave in Node.js.--localstorage-fileflag determines the file used forlocalStorage.Example documentation snippet added:
Note
--localstorage-fileoption is currently documented but not implemented in the Node.js core. Therefore, the added documentation is primarily for reference and future-proofing.Please review the documentation updates, and let me know if there are any additional changes or clarifications needed.