tools: update sdwrap.py to use Python3.8 features#54348
Closed
avivkeller wants to merge 2 commits intonodejs:mainfrom
Closed
tools: update sdwrap.py to use Python3.8 features#54348avivkeller wants to merge 2 commits intonodejs:mainfrom
sdwrap.py to use Python3.8 features#54348avivkeller wants to merge 2 commits intonodejs:mainfrom
Conversation
avivkeller
added
the
python
Member
This file is only used on z/OS. |
anonrig
reviewed
Aug 13, 2024
tools/zos/sdwrap.py
Outdated
|
|
||
| return 0 | ||
| firstline = True | ||
| while (line := args.input.read(72)): |
Member
There was a problem hiding this comment.
This change also updates indentation from 2 to 4.
avivkeller
added
the
commit-queue-squash
Member
Author
|
I'm going to do this in conjunction with some lint changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js can't be built without Python 3.8, so this PR updates the
sdwrap.pyfile to use features introduced up until that point.Ref: #54112