Fix doc net connection #54194
Merged
Fix doc net connection #54194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
ShogunPanda
approved these changes
Aug 4, 2024
avivkeller
added
the
commit-queue-squash
lpinca
approved these changes
Aug 4, 2024
daeyeon
added
author ready
pimterry
approved these changes
Aug 5, 2024
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a5200da |
Merged
Member
|
Minor nit, but would it be possible to also move the YAML - version: v12.10.0
pr-url: https://github.com/nodejs/node/pull/25436
description: Added `onread` option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53792
As
net.connect()is alias ofnet.createConnection()and all of the detailed descriptions are written in latter one, thenet.connect()function example is moved tonet.createConnection()section and the name of function in the example code is altered tonet.createConnection().