src: add missing to_ascii method in dns queries#48347
Closed
anonrig wants to merge 1 commit intonodejs:mainfrom
Closed
src: add missing to_ascii method in dns queries#48347anonrig wants to merge 1 commit intonodejs:mainfrom
anonrig wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
ShogunPanda
approved these changes
Jun 5, 2023
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
removed
the
author ready
lemire
reviewed
Jun 5, 2023
| auto wrap = std::make_unique<Wrap>(channel, req_wrap_obj); | ||
|
|
||
| node::Utf8Value name(env->isolate(), string); | ||
| auto plain_name = |
Member
There was a problem hiding this comment.
I am not sure this code is safe because it appears that temporary objects are created, and they go out of scope. The result of node::Utf8Value is converted to a string_view, but a string_view pointing at what instance? It is unclear to me.
I recommend breaking this down...
Local<String> string = args[1].As<String>();
node::Utf8Value utf8name(env->isolate(), string);
std::string name = ada::idna::to_ascii(utf8name.ToStringView());
Member
Author
There was a problem hiding this comment.
@lemire Would you like to takeover this pull request? Unfortunately, I can't complete it soon.
Member
Author
|
Closing in favor of @lemire 's pull request |
This was referenced Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48262
cc @targos @ShogunPanda