Revert "stream: add bytesRead property for readable"#4746
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
Revert "stream: add bytesRead property for readable"#4746cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit bfb2cd0. Refs: nodejs#4372
Contributor
|
cc @jasnell also, who landed it. |
Member
|
LGTM but the body of the commit log should explain why it got reverted. Something like: "The property tracks characters instead of bytes when using an identity encoding." |
Member
|
LGTM |
Contributor
|
+10 to adding reason(s) when reverting commits. |
Contributor
Author
|
I'l update the commit log before I land it. |
Contributor
Author
|
Revert landed in eee9dc7. |
Member
|
added |
Contributor
Author
|
@rvagg that sounds correct. |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
This reverts commit bfb2cd0. The bytesRead property, as implemented, tracks characters instead of bytes when using an identity encoding. Refs: nodejs#4372 PR-URL: nodejs#4746 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit bfb2cd0.
Refs: #4372
R= @bnoordhuis