[v19.x backport] deps: V8: cherry-pick cb30b8e17429 by RaisinTen · Pull Request #47307 · nodejs/node

RaisinTen · 2023-03-30T07:50:31Z

Original commit message:

Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.

Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86235}

Refs: v8/v8@cb30b8e
Refs: #43370

nodejs-github-bot · 2023-03-30T07:50:35Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

targos · 2023-03-31T14:19:32Z

I just landed V8 11.3 on main and it contains this fix. You might want to backport to v19.x-staging instead.

Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: nodejs#43370 Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen · 2023-04-03T09:56:02Z

@targos done, could you PTAL?

nodejs-github-bot · 2023-04-04T01:14:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50889/

nodejs-github-bot · 2023-04-04T04:59:08Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5269/

nodejs-github-bot · 2023-04-04T05:01:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5269/

nodejs-github-bot · 2023-04-04T05:05:28Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5269/

RaisinTen · 2023-04-04T14:10:36Z

@targos it seems like the only remaining CI failure on this PR is coming from https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5269/:

Details

Testing hash seed
export PATH="/usr/bin:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" && \
	/usr/bin/python3.9 deps/v8/tools/run-tests.py --gn --arch=ppc64 --progress=dots --timeout=120 intl \
			mjsunit cctest debugger inspector message preparser \
			--json-test-results /home/iojs/build/workspace/node-test-commit-v8-linux/v8-tap.json --slow-tests-cutoff 1000000
Traceback (most recent call last):
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/run-tests.py", line 11, in <module>
    from testrunner import standard_runner
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/standard_runner.py", line 16, in <module>
    from testrunner.testproc.progress import ResultsTracker, ProgressProc
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/progress.py", line 9, in <module>
    from testrunner.testproc.resultdb import ResultDBIndicator
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/resultdb.py", line 8, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
make: *** [Makefile:713: test-v8] Error 1
Build step 'Execute shell' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com vieuxtech@gmail.com info@bnoordhuis.nl
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE

which looks totally unrelated. Is this a known issue on v19.x-staging? Should we land this PR manually irrespective of that failure?

targos · 2023-04-04T14:54:50Z

Yes, it's a known issue fixed by #47239

Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: #43370 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47307 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

RaisinTen · 2023-04-05T12:30:04Z

Landed in 5ddd1c9

Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: #43370 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47307 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 30, 2023

targos approved these changes Mar 30, 2023

View reviewed changes

RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

This comment was marked as outdated.

Sign in to view

gengjiawen approved these changes Mar 30, 2023

View reviewed changes

RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2023

richardlau approved these changes Mar 30, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

cjihrig approved these changes Mar 30, 2023

View reviewed changes

github-actions bot mentioned this pull request Mar 31, 2023

CI Reliability 2023-03-31 nodejs/reliability#535

Open

34 tasks

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Mar 31, 2023

View reviewed changes

github-actions bot mentioned this pull request Apr 1, 2023

CI Reliability 2023-04-01 nodejs/reliability#536

Open

38 tasks

RaisinTen changed the base branch from main to v19.x-staging April 3, 2023 09:37

RaisinTen changed the title ~~deps: V8: cherry-pick cb30b8e17429~~ [v19.x] deps: V8: cherry-pick cb30b8e17429 Apr 3, 2023

RaisinTen force-pushed the fix-compilation-error-in-platform.h-for-ASAN branch from 995715a to 97f9fbc Compare April 3, 2023 09:54

RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2023

RaisinTen changed the title ~~[v19.x] deps: V8: cherry-pick cb30b8e17429~~ [v19.x backport] deps: V8: cherry-pick cb30b8e17429 Apr 3, 2023

RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2023

This comment was marked as outdated.

Sign in to view

targos approved these changes Apr 3, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2023

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Apr 4, 2023

CI Reliability 2023-04-04 nodejs/reliability#539

Open

29 tasks

targos added the v19.x label Apr 4, 2023

github-actions bot mentioned this pull request Apr 5, 2023

CI Reliability 2023-04-05 nodejs/reliability#540

Open

26 tasks

RaisinTen closed this Apr 5, 2023

RaisinTen deleted the fix-compilation-error-in-platform.h-for-ASAN branch April 5, 2023 12:30

richardlau mentioned this pull request Apr 6, 2023

[v19.x] deps: V8: cherry-pick f09dde9fbb54 #47239

Closed

RafaelGSS mentioned this pull request Apr 6, 2023

v19.9.0 proposal #47441

Merged

Uh oh!

Conversation

RaisinTen commented Mar 30, 2023

Uh oh!

nodejs-github-bot commented Mar 30, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

targos commented Mar 31, 2023

Uh oh!

RaisinTen commented Apr 3, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

nodejs-github-bot commented Apr 4, 2023

Uh oh!

RaisinTen commented Apr 4, 2023

Uh oh!

targos commented Apr 4, 2023

Uh oh!

RaisinTen commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants