deps: cherry-pick libuv@e900006 and libuv@64669fd#45561
Closed
qdaoming wants to merge 1 commit intonodejs:mainfrom
Closed
deps: cherry-pick libuv@e900006 and libuv@64669fd#45561qdaoming wants to merge 1 commit intonodejs:mainfrom
qdaoming wants to merge 1 commit intonodejs:mainfrom
Conversation
Original commit log for libuv@e900006 follows: thread: add support for affinity (nodejs#3774) Backported thread affinity feature and related dependency commits from master. It will add support for those APIs: uv_cpumask_size, uv_thread_setaffinity, uv_thread_getaffinity. The supported platforms are Linux, Freebsd, and Windows. Empty implementations (returning UV_ENOTSUP) on non-supported platforms (such as OS X and AIX). Original commit log for libuv@64669fd follows: thread: add uv_thread_getcpu() (nodejs#3803) Add uv_thread_getcpu() api to get the cpu number on which the calling thread is running.
nodejs-github-bot
added
libuv
Member
|
The commit is not included in a release yet, so I would wait and update to the next version of libuv instead of cherry picking commits from the v1.x branch. |
Contributor
Author
Contributor
|
@qdaoming-intel we generally try not to cherry-pick commits from libuv. That project is run mostly by Node.js collaborators, so you could try requesting a release on the libuv issue tracker. |
Member
|
We generally do not want to cherry pick features for dependencies -- if we were to start using this new API it will break anyone building Node.js against a shared libuv (e.g. Linux distros). |
Contributor
Author
|
OK. I will close this PR and waits for libuv updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit log for libuv@e900006 follows:
thread: add support for affinity (#3774)
Backported thread affinity feature and related dependency commits from master. It will add support for those APIs: uv_cpumask_size, uv_thread_setaffinity, uv_thread_getaffinity.
The supported platforms are Linux, Freebsd, and Windows. Empty implementations (returning UV_ENOTSUP) on non-supported platforms (such as OS X and AIX).
Original commit log for libuv@64669fd follows:
thread: add uv_thread_getcpu() (#3803)
Add uv_thread_getcpu() api to get the cpu number on which the calling thread is running.