[v16.x backport] net: add new options to net.Socket and net.Server#42298
Closed
aduh95 wants to merge 2 commits intonodejs:v16.x-stagingfrom
Closed
[v16.x backport] net: add new options to net.Socket and net.Server#42298aduh95 wants to merge 2 commits intonodejs:v16.x-stagingfrom
net.Socket and net.Server#42298aduh95 wants to merge 2 commits intonodejs:v16.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
e1c7592 to
5e48375
Compare
728b657 to
79e2ab2
Compare
Contributor
|
@aduh95 can you rebase this? |
PR-URL: nodejs#41310 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: nodejs#41310 PR-URL: nodejs#42268 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
5e48375 to
ce4a7e1
Compare
Collaborator
Collaborator
danielleadams
approved these changes
Apr 11, 2022
Contributor
|
Landed in 85e3624...f8819e8 |
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2022
PR-URL: #41310 Backport-PR-URL: #42298 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2022
Refs: #41310 PR-URL: #42268 Backport-PR-URL: #42298 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41310 and #42268.