configure: fix arm vfpv2#4202
Closed
joerg-krause wants to merge 1 commit intonodejs:v4.xfrom
joerg-krause:v4.x-fix-arm-vfpv2
Closed
configure: fix arm vfpv2#4202joerg-krause wants to merge 1 commit intonodejs:v4.xfrom joerg-krause:v4.x-fix-arm-vfpv2
joerg-krause wants to merge 1 commit intonodejs:v4.xfrom
joerg-krause:v4.x-fix-arm-vfpv2
Conversation
The gcc -mfpu flag for VFPv2 is 'vfp', not 'vfpv2' [1]. [1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
Member
|
LGTM but this should go into master first and then get cherry-picked to v4.x. CI against master: https://ci.nodejs.org/job/node-test-pull-request/962/ |
bnoordhuis
added
build
Contributor
Author
|
Shall I recreate the PR against master? |
Member
|
You don't have to, we'll make sure it gets landed on the right branch. |
Member
|
On second thought, would you mind filing a new PR? It doesn't look to be applying to master cleanly. |
Contributor
Author
|
I'll close as I recreated a PR #4203 against the master branch. |
This was referenced Aug 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gcc
-mfpuflag for VFPv2 isvfp, notvfpv2(there is novfpv2) [1].[1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html