Skip to content

Update my email address#40102

Closed
GeoffreyBooth wants to merge 3 commits intonodejs:masterfrom
GeoffreyBooth:geoffrey-update-email
Closed

Update my email address#40102
GeoffreyBooth wants to merge 3 commits intonodejs:masterfrom
GeoffreyBooth:geoffrey-update-email

Conversation

@GeoffreyBooth
Copy link
Member

@GeoffreyBooth GeoffreyBooth commented Sep 14, 2021

Shoulda done this awhile ago.

@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 72 hours to land. label Sep 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2021

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 14, 2021
@Trott
Copy link
Member

Trott commented Sep 14, 2021

While we're in here, can we add a .mailmap entry and re-run tools/update-authors.js? You have two entries in the AUTHORS file. (This is a non-blocking request. If this lands, I'll just do this in a later PR anyway, as I've been doing for others, such as in #40103.)

@Trott
Copy link
Member

Trott commented Sep 14, 2021

While we're in here, can we add a .mailmap entry and re-run tools/update-authors.js? You have two entries in the AUTHORS file. (This is a non-blocking request. If this lands, I'll just do this in a later PR anyway, as I've been doing for others, such as in #40103.)

Er, actually, I guess it would be 2 .mailmap entries. In addition to this change, we also need one for GeoffreyBooth@users.noreply.github.com. (But again, I'll do it if you don't. But if you don't mind, please add it to this! Thanks!)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 14, 2021
@GeoffreyBooth
Copy link
Member Author

GeoffreyBooth commented Sep 14, 2021

@Trott can you confirm that I did this right? I hadn’t heard of the .mailmap file before.

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 72 hours to land. label Sep 16, 2021
aduh95 pushed a commit that referenced this pull request Sep 16, 2021
@GeoffreyBooth @aduh95
meta: update GeoffreyBooth email address
c365145 
PR-URL: #40102
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Sep 16, 2021

Landed in c365145

@aduh95 aduh95 closed this Sep 16, 2021
@GeoffreyBooth GeoffreyBooth deleted the geoffrey-update-email branch September 16, 2021 22:46
@Trott
Copy link
Member

Trott commented Sep 17, 2021

@Trott can you confirm that I did this right? I hadn’t heard of the .mailmap file before.

Sorry I'm late to this. I don't think the .mailmap entry is quite right, but that's OK, I'll tidy it up along with a few other entries. Sorry I didn't respond sooner!

BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@GeoffreyBooth @BethGriggs
meta: update GeoffreyBooth email address
e82be2d 
PR-URL: #40102
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@GeoffreyBooth @BethGriggs
meta: update GeoffreyBooth email address
effdfa9 
PR-URL: #40102
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GeoffreyBooth @Trott @aduh95 @jasnell @tniessen @Ayase-252 @nodejs-github-bot