build: make scripts in gyp run with right python#39730
Closed
zcbenz wants to merge 1 commit intonodejs:masterfrom
Closed
build: make scripts in gyp run with right python#39730zcbenz wants to merge 1 commit intonodejs:masterfrom
zcbenz wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
i18n-api
targos
approved these changes
Aug 11, 2021
addaleax
approved these changes
Aug 11, 2021
legendecas
approved these changes
Aug 11, 2021
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Aug 12, 2021
lpinca
approved these changes
Aug 13, 2021
Ayase-252
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in a3c0713...92090d3 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
PR-URL: #39730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #39730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should use
<(python)instead ofpythonfor scripts in gyp files, otherwise the scripts might be run with python2 on some environments.