lib: cache process.binding(…) wrappers

[ExE-Boss]

Currently, process.binding("util") === process.binding("util") is true, this ensures that with #37819, process.binding("util") === process.binding("util") remains true.

---

Refs: #37819

[aduh95]

Suggested change

	if (!result) {
	result = factory();
	}
	result ||= factory();

but do we want falsy or nullish?

Suggested change

	if (!result) {
	result = factory();
	}
	result ??= factory();

[ExE-Boss]

Arguably, it can just be return result ??= factory().

[aduh95]

Arguably, it can just be return result ??= factory().

I don't know if we have a linter rule enforcing that, but I think we tend to avoid mixing assignments and return statements in the code base, to improve readability.

[RaisinTen]

There are a couple of assignments in return statements:

$ git grep "return .* = " lib

Since this is a smallish statement, should we prefer return result ??= factory();?

[addaleax]

Arguably, it can just be return result ??= factory().

I don't know if we have a linter rule enforcing that, but I think we tend to avoid mixing assignments and return statements in the code base, to improve readability.

Why would that improve readability?

[aduh95]

Could we avoid the %Object.fromEntries% call in factories and the followup%Object.entries% call in the module.exports? Or refactor factories be an array maybe?

[addaleax]

Currently, process.binding("util") === process.binding("util") is true, this ensures that with #37819, process.binding("util") === process.binding("util") remains true.

To be frank – Why do we care? This is not something that userland code would be expected to rely on, and the point here is to reduce maintenance overhead by putting code in a separate file and not caring about that beyond minimal maintenance. Yes, it’s a bit slower to access the bindings this way, but that’s just fine too.

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.