Closed
Conversation
nodejs-github-bot
added
needs-ci
Collaborator
ruyadorno
added
the
fast-track
Member
Author
|
fast-track? |
Collaborator
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Mar 12, 2021
aduh95
approved these changes
Mar 12, 2021
Contributor
|
Do we really need a passing Jenkins CI for an npm update? I believe we don't test anything related to npm that the GitHub Actions CI doesn't already check. |
Member
|
@aduh95 we have at least one npm test: https://github.com/nodejs/node/blob/master/test/parallel/test-npm-install.js |
Member
Author
|
@targos I don't think that one is actually running on CI 😅 I have seen it broken on the main branch and had to manually fix it later many times |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
Trott
pushed a commit
that referenced
this pull request
Mar 13, 2021
PR-URL: #37721 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Member
|
Landed in 5fdcfb3 |
Member
There's also test-release-npm.js and test-npm-version.js. |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37721 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37721 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7.6.3 (2021-03-11)
DOCUMENTATION
8c44e999b#2855 Correct "npm COMMAND help" to "npm help COMMAND" (@dwardu)DEPENDENCIES
57ed390d6@npmcli/[email protected]v7.6.2 (2021-03-09)
BUG FIXES
e0a3a5218#2831 Fix cb() never called in search with --json option (@fraqe)85a8694dd#2795 fix(npm.output): make output go through npm.output (@wraithgar)9fe0df5b5#2821 fix(usage): clean up usage declarations (@wraithgar)DEPENDENCIES
7f470b5c2@npmcli/[email protected]e9b7fc275[email protected]c7314aa62[email protected]864f48d43[email protected]