cluster: restructure to same prototype for cluster child#36610
Closed
yashLadha wants to merge 1 commit intonodejs:masterfrom
Closed
cluster: restructure to same prototype for cluster child#36610yashLadha wants to merge 1 commit intonodejs:masterfrom
yashLadha wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
cluster
jasnell
approved these changes
Dec 31, 2020
Collaborator
aduh95
added
the
author ready
Contributor
|
This needs a rebase. |
aduh95
removed
the
author ready
marsonya
approved these changes
Feb 22, 2021
yashLadha
force-pushed
the
fix_generic_handling
branch
2 times, most recently
from
87cdb48 to
1fac05e
Compare
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing.
yashLadha
force-pushed
the
fix_generic_handling
branch
from
1fac05e to
b122e83
Compare
aduh95
added
the
author ready
Collaborator
Collaborator
Member
|
Landed in c199989 |
jasnell
pushed a commit
that referenced
this pull request
Mar 5, 2021
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing. PR-URL: #36610 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing. PR-URL: #36610 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
rrandsharedboth belongs to the same prototype declarationand differes only in the handler declaration, this can be abstracted to
a same type of function arguments passing. Motivation behind this is they are
just extended handlers performing the same basic task so the layout (function structure)
should be consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes