tools,lib: refactor prefer-primordials rule#36018
Merged
aduh95 merged 1 commit intonodejs:masterfrom Feb 16, 2021
Merged
Conversation
nodejs-github-bot
added
process
github-actions
bot
removed
the
request-ci
Collaborator
Leko
suggested changes
Nov 7, 2020
Contributor
Leko
left a comment
Leko
left a comment
There was a problem hiding this comment.
Could you separate this pull request for each purpose?
- Refactoring of the rule
- Add
Safeprefix on the Map and Set, etc. - Replace
prototypeproperty with primordials.
Leko
suggested changes
Nov 7, 2020
aduh95
force-pushed
the
prefer-primordials-refactor
branch
from
5ef69fb to
601d050
Compare
Member
|
Not sure if this needs to be rebased or closed (since it overlaps with PRs that landed?) but one or the other. |
aduh95
force-pushed
the
prefer-primordials-refactor
branch
from
601d050 to
599119c
Compare
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Member
|
Blocked on nodejs/build#2504. |
Contributor
|
nodejs/build#2504 has now been fixed by nodejs/build#2514. |
Collaborator
Collaborator
Contributor
Author
|
@Leko I think this is ready to land, would you kindly have another look at this PR, I believe I've addressed all your objections. |
aduh95
added
the
author ready
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: nodejs#36018 Reviewed-By: Shingo Inoue <[email protected]>
aduh95
force-pushed
the
prefer-primordials-refactor
branch
from
599119c to
7fd6c20
Compare
Contributor
Author
|
Landed in 7fd6c20 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 27, 2021
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Use optional chaining to improve code readability and remove use of `Array.prototype.reduce`. PR-URL: #36018 Reviewed-By: Shingo Inoue <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the ESLint rule source code to improve readability.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes