common.mustCall() is added

[PoojaDurgad]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32979/

[Trott]

This gives a false sense of security. This is a child process and if the child process fails, it doesn't affect the test. You can see this if you add a 2 as the second argument to common.mustCall() so that it causes an assertion. It will print the assertion message, but the test still passes.

$ ./node test/sequential/test-net-response-size.js
Server running.
server received 65536 bytes
server received 36864 bytes
server received 1 bytes
Mismatched <anonymous> function calls. Expected exactly 2, actual 1.
    at Proxy.mustCall (/Users/trott/io.js/test/common/index.js:329:10)
    at Object.<anonymous> (/Users/trott/io.js/test/sequential/test-net-response-size.js:35:42)
    at Module._compile (internal/modules/cjs/loader.js:1090:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1111:10)
    at Module.load (internal/modules/cjs/loader.js:955:32)
    at Function.Module._load (internal/modules/cjs/loader.js:796:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
$ tools/test.py test/sequential/test-net-response-size.js
[00:01|% 100|+   1|-   0]: Done                          
$ 

[PoojaDurgad]

I understand that this is not so useful because common.mustcall() is enclosed in child process. Thanks for the replay and I will close the PR.

[Trott]

Same problem as above.

$ ./node test/sequential/test-net-response-size.js       
Server running.
server received 65536 bytes
server received 36864 bytes
server received 1 bytes
Mismatched <anonymous> function calls. Expected exactly 2, actual 1.
    at Proxy.mustCall (/Users/trott/io.js/test/common/index.js:329:10)
    at Object.<anonymous> (/Users/trott/io.js/test/sequential/test-net-response-size.js:45:50)
    at Module._compile (internal/modules/cjs/loader.js:1090:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1111:10)
    at Module.load (internal/modules/cjs/loader.js:955:32)
    at Function.Module._load (internal/modules/cjs/loader.js:796:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
$ tools/test.py test/sequential/test-net-response-size.js
[00:01|% 100|+   1|-   0]: Done                          
$

[Trott]

Welcome, @PoojaDurgad, and thanks for the pull request! I appreciate the effort, but I don't think we should do this for the reasons described in the comments.

[PoojaDurgad]

Thanks,@Trott ,for reviewing my pull request and I understand that this is not so useful.