module: fix check for package.json at volume root#33476
Merged
GeoffreyBooth merged 1 commit intonodejs:masterfrom May 22, 2020
Merged
module: fix check for package.json at volume root#33476GeoffreyBooth merged 1 commit intonodejs:masterfrom
GeoffreyBooth merged 1 commit intonodejs:masterfrom
Conversation
GeoffreyBooth
added
the
esm
Collaborator
guybedford
reviewed
May 20, 2020
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Note we also have the esm resolver case to check too? Or is that already working?
Member
Author
That seems to already be working. I did the test described in #33438 and got that to pass. I also tested one level down, where an |
ljharb
reviewed
May 20, 2020
GeoffreyBooth
force-pushed
the
fix-package-json-type-at-root
branch
from
e34cc24 to
036dfc1
Compare
Collaborator
GeoffreyBooth
force-pushed
the
fix-package-json-type-at-root
branch
from
036dfc1 to
cd2dc86
Compare
Collaborator
Collaborator
Member
Author
|
https://ci.nodejs.org/job/node-test-pull-request/31458/ is green, dunno what's going on with the GitHub Actions. |
hybrist
approved these changes
May 21, 2020
GeoffreyBooth
force-pushed
the
fix-package-json-type-at-root
branch
from
cd2dc86 to
a94a5ba
Compare
Member
Author
|
Landed in 51af89f. |
Merged
Member
|
@guybedford this caused a CITGM failure on v14.x - see #34093 (comment) |
Merged
Contributor
|
Just got bit by this in prepping v14.6.0 I think we should revert this change as it is causing broad failures in various modules |
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
Jul 16, 2020
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: nodejs#33476
MylesBorins
added a commit
that referenced
this pull request
Jul 20, 2020
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: #33476 PR-URL: #34403 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
|
This change has been reverted on master. |
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: * coffeescript * JSONStream * gulp * and more We should reopen a PR to figure out how to land this in a way that is non-breaking. Refs: #33476 PR-URL: #34403 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33438. A
package.jsonat the volume root containing"type": "module"now behaves as documented. Thanks to @vitalets for pinpointing exactly where the problem was.No idea how to write a test for this, but I tested it manually and this fixes the issue.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/modules-active-members