worker: fix type check in receiveMessageOnPort#32745
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
worker: fix type check in receiveMessageOnPort#32745addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: nodejs#32742
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Apr 9, 2020
Flarna
approved these changes
Apr 9, 2020
addaleax
added
the
author ready
Collaborator
ZYSzys
reviewed
Apr 10, 2020
| if (!args[0]->IsObject() || | ||
| !env->message_port_constructor_template()->HasInstance(args[0])) { | ||
| return THROW_ERR_INVALID_ARG_TYPE(env, | ||
| "First argument needs to be a MessagePort instance"); |
Member
There was a problem hiding this comment.
To be consistent with the doc, maybe change to:
Suggested change
| "First argument needs to be a MessagePort instance"); | |
| 'The "port" argument must be a MessagePort instance'); |
Member
Author
There was a problem hiding this comment.
@ZYSzys Do you maybe want to open a PR after this lands that makes this consistent across both instances?
Member
There was a problem hiding this comment.
Aha, I missed that there is still somewhere else need to be consistent.
Make sense to do it entirely after this lands.
Member
|
LGTM. |
Collaborator
ZYSzys
approved these changes
Apr 10, 2020
Collaborator
himself65
approved these changes
Apr 13, 2020
Collaborator
addaleax
added a commit
that referenced
this pull request
Apr 13, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Member
Author
|
Landed in a46345d |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Apr 13, 2020
3 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
addaleax
added a commit
that referenced
this pull request
Apr 15, 2020
Refs: #32745 (comment) PR-URL: #32815 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
Refs: #32745 (comment) PR-URL: #32815 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: nodejs#32742 PR-URL: nodejs#32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Member
|
This looks dependent on #27294 which has a backport requested for 10.x label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same type check we use in
MoveToContext()inReceiveMessage().Fixes: #32742
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes