doc: add zlib maintenance doc#31800

Closed

sam-github wants to merge 3 commits intonodejs:masterfrom

sam-github:update-zlib

Contributor

sam-github commented Feb 14, 2020

Add a maintenance doc for deps/zlib, and run the process.

Result is an almost entirely empty "update" (only the mode of one file was different from upstream).

Note: we changed to using a google repo as upstream in #31201

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot added the zlib label

sam-github requested a review from mscdex

February 14, 2020 21:15

sam-github mentioned this pull request

deps: switch to chromium's zlib implementation #31201

Merged

3 tasks

jasnell approved these changes

View reviewed changes

mscdex reviewed

View reviewed changes

doc/guides/maintaining-zlib.md Outdated Show resolved Hide resolved

mscdex reviewed

View reviewed changes

doc/guides/maintaining-zlib.md Outdated Show resolved Hide resolved

cjihrig approved these changes

View reviewed changes

sam-github force-pushed the update-zlib branch from c2d51de to 78cc6c9 Compare

February 18, 2020 19:06

Collaborator

nodejs-github-bot commented Feb 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29217/

Collaborator

nodejs-github-bot commented Feb 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29222/

sam-github added 3 commits

February 18, 2020 14:19


          deps: move zlib maintenance info to guides

07fbe15

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.


          doc: describe how to update zlib

fb7cccb

See:
- nodejs#31201


          deps: update zlib to upstream d7f3ca9

f70ebe6

Updated as described in doc/guides/maintaining-zlib.md.

sam-github force-pushed the update-zlib branch from 78cc6c9 to f70ebe6 Compare

February 18, 2020 22:19

Collaborator

nodejs-github-bot commented Feb 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29224/

BethGriggs approved these changes

View reviewed changes

Contributor Author

sam-github commented Feb 24, 2020

Landed in b70dd9d...9a1719b

sam-github closed this

sam-github added a commit that referenced this pull request


          deps: move zlib maintenance info to guides

5f0181a

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

sam-github added a commit that referenced this pull request


          doc: describe how to update zlib

0d95eda

See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

sam-github added a commit that referenced this pull request


          deps: update zlib to upstream d7f3ca9

9a1719b

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

sam-github deleted the update-zlib branch

February 24, 2020 19:53

codebytere pushed a commit that referenced this pull request


          deps: move zlib maintenance info to guides

b30a698

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          doc: describe how to update zlib

4c6343f

See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          deps: update zlib to upstream d7f3ca9

c27f0d1

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere mentioned this pull request

v13.10.0 proposal #32027

Merged

codebytere pushed a commit that referenced this pull request


          deps: move zlib maintenance info to guides

7e28ba4

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          doc: describe how to update zlib

d8447fa

See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          deps: update zlib to upstream d7f3ca9

e09bd5c

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          deps: move zlib maintenance info to guides

8de377d

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          doc: describe how to update zlib

6fe592e

See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere pushed a commit that referenced this pull request


          deps: update zlib to upstream d7f3ca9

5f866e4

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

codebytere mentioned this pull request

v12.16.2 proposal #32313

Merged

targos added the backport-blocked-v12.x label

Member

targos commented Apr 18, 2020

depends on the zlib update to land on v12.x

targos pushed a commit to targos/node that referenced this pull request


          deps: move zlib maintenance info to guides

c24899d

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: nodejs#31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos pushed a commit to targos/node that referenced this pull request


          doc: describe how to update zlib

32533d6

See:
- nodejs#31201

PR-URL: nodejs#31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos pushed a commit to targos/node that referenced this pull request


          deps: update zlib to upstream d7f3ca9

5467c74

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: nodejs#31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos removed the backport-blocked-v12.x label

targos pushed a commit that referenced this pull request


          deps: move zlib maintenance info to guides

9a89718

deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos pushed a commit that referenced this pull request


          doc: describe how to update zlib

3e939ff

See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos pushed a commit that referenced this pull request


          deps: update zlib to upstream d7f3ca9

1b53e17

Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos mentioned this pull request

v12.17.0 release proposal #33197

Merged

zmodem commented Sep 14, 2020

Hi Sam,

We fixed a zlib bug in Chromium recently (https://crbug.com/1103818) which can cause incorrect inflate results when using newer Clang versions. It might be worth rolling forward again to pick up that fix.

Also it seems there's another copy of zlib in Node that comes in via V8's dependencies: https://github.com/nodejs/node/tree/master/deps/v8/third_party/zlib
I don't know if both copies are used when building Node, but maybe that needs an update too.

Thanks,
Hans

RaisinTen mentioned this pull request

clang-12 + Release mode causes zlib failures (apparent data corruption) #39313

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zlib