tls: Fix crash when internal debug enabled#31511
Closed
rustyconover wants to merge 1 commit intonodejs:masterfrom
Closed
tls: Fix crash when internal debug enabled#31511rustyconover wants to merge 1 commit intonodejs:masterfrom
rustyconover wants to merge 1 commit intonodejs:masterfrom
Conversation
When NODE_DEBUG_NATIVE is enabled for tls a debug statement is sometimes called with error_str set to null, this causes a crash from glibc since string format parameters should not be null.
nodejs-github-bot
added
c++
Member
|
Sorry – this might be something I didn’t catch during #31446 – Maybe we could update the |
Contributor
Author
|
See PR #31523. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NODE_DEBUG_NATIVE is enabled for tls a debug statement
is sometimes called with error_str set to null, this causes
a crash from glibc since string format parameters should not
be null.
make -j4 test(UNIX), orvcbuild test(Windows) passes