doc: prefer server over srv#31224
Closed
andrewhughes101 wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
sam-github
reviewed
Jan 6, 2020
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
I've no strong opinions here, but changing srv without changing clt somewhat increases the inconsistency, IMO.
doc/api/http.md
Outdated
Contributor
There was a problem hiding this comment.
Also, notice the obiquitous use use TLAs in the HTTP API.
Trott
reviewed
Jan 6, 2020
Member
There was a problem hiding this comment.
Optional nit: doc/STYLE_GUIDE.md codifies a preference for American spellings, so s/standardise/standardize/ in the commit messages maybe?
Or get rid of standardi[sz]e altogether and go with something like test: prefer server over srv and doc: prefer server over srv?
Without a lint rule, it seems likely that srv will creep back in at some point. But in general I prefer longer and more descriptive variable names to abbreviated ones, so I'm OK with this.
andrewhughes101
force-pushed
the
http-docs
branch
from
6ba0c54 to
87c536f
Compare
Contributor
Author
|
Thanks for the reviews, Ive changed |
andrewhughes101
changed the title
sam-github
approved these changes
Jan 7, 2020
richardlau
approved these changes
Jan 7, 2020
BethGriggs
approved these changes
Jan 7, 2020
lpinca
approved these changes
Jan 7, 2020
BridgeAR
added
the
author ready
Trott
approved these changes
Jan 8, 2020
BridgeAR
added
doc
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
Landed in f2a089a...b0f67f2 |
Trott
pushed a commit
that referenced
this pull request
Jan 9, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
pushed a commit
that referenced
this pull request
Jan 9, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed http tests and documentation to use
serverinstead of a mixture ofsrvandserverChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes