http2: set stricter default maxConcurrentStreams#29833
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:http2-setting-maxConcurrentStreams
Closed
http2: set stricter default maxConcurrentStreams#29833ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:http2-setting-maxConcurrentStreams
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:http2-setting-maxConcurrentStreams
Conversation
Set the default maxConcurrentStreams to NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS.
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 3, 2019
devnexen
approved these changes
Oct 3, 2019
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Oct 3, 2019
Collaborator
trivikr
added
the
author ready
trivikr
approved these changes
Oct 4, 2019
cjihrig
approved these changes
Oct 4, 2019
antsmartian
approved these changes
Oct 5, 2019
ZYSzys
added a commit
that referenced
this pull request
Oct 5, 2019
Set the default maxConcurrentStreams to NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS. PR-URL: #29833 Fixes: #29763 Refs: nghttp2/nghttp2@16c4611 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Member
Author
|
Landed in f0bee9b. |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Set the default maxConcurrentStreams to NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS. PR-URL: #29833 Fixes: #29763 Refs: nghttp2/nghttp2@16c4611 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the default maxConcurrentStreams to
NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS(0xffffffffu) and expose it so that we can get this value fromhttp2.getDefaultSettings().The original
NGHTTP2_INITIAL_MAX_CONCURRENT_STREAMS(2 ** 31 - 1) was deprecated according to nghttp2, so I set the default maxConcurrentStreams toNGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS(0xffffffffu) here:node/deps/nghttp2/lib/nghttp2_session.h
Lines 102 to 103 in 88ef086
node/deps/nghttp2/lib/includes/nghttp2/nghttp2.h
Lines 699 to 716 in 88ef086
Fixes: #29763
Refs: nghttp2/nghttp2@16c4611
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes