Skip to content

doc: clarify napi_finalize related APIs#29797

Closed
legendecas wants to merge 1 commit intonodejs:masterfrom
legendecas:issue-29750
Closed

doc: clarify napi_finalize related APIs#29797
legendecas wants to merge 1 commit intonodejs:masterfrom
legendecas:issue-29750

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Oct 1, 2019

All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: #29750

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 1, 2019
@legendecas legendecas changed the title n-api,doc: clarify napi_finalize related APIs doc: clarify napi_finalize related APIs Oct 1, 2019
gabrielschulhof
gabrielschulhof approved these changes Oct 1, 2019
View reviewed changes
@legendecas
n-api,doc: clarify napi_finalize related APIs
7543a4a 
All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: nodejs#29750
@trivikr

This comment has been minimized.

Sign in to view
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2019
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3965/

mhdawson
mhdawson approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Oct 3, 2019

Landed in a71fb97

@Trott Trott closed this Oct 3, 2019
Trott pushed a commit that referenced this pull request Oct 3, 2019
@legendecas @Trott
n-api,doc: clarify napi_finalize related APIs
a71fb97 
All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: #29750

PR-URL: #29797
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@legendecas legendecas deleted the issue-29750 branch October 4, 2019 00:45
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@legendecas @BridgeAR
n-api,doc: clarify napi_finalize related APIs
20896f7 
All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: #29750

PR-URL: #29797
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

n-api,doc: statements on conflicts on adding finalizers

6 participants

@legendecas @trivikr @Trott @gabrielschulhof @mhdawson @nodejs-github-bot