doc: fix return type#29696
Closed
exoego wants to merge 2 commits intonodejs:masterfrom
exoego:doc-crypto
Closed
Conversation
Member
|
@nodejs/crypto |
Contributor
|
If this will be accepted, we also need to update the type parser, i.e. to add an entry after this line: Line 54 in 7333c71 |
Member
It will have to happen in this PR or else |
Member
|
@nodejs/crypto @nodejs/documentation This could use reviews. |
Member
|
@nodejs/collaborators |
Trott
approved these changes
Oct 4, 2019
Member
|
Rebased and force-pushed. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3970/ |
Trott
approved these changes
Oct 4, 2019
Trott
pushed a commit
that referenced
this pull request
Oct 4, 2019
PR-URL: #29696 Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 03b7a5a |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #29696 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IIUC,
crypto.createDiffieHellmanGroup(name)and its originalcrypto.getDiffieHellman(groupName)will return a instance ofDiffieHellmanGroupwhich is not a sub type ofDiffieHellman.on Node.js v12.10.0.
Checklist