tools: update eslint to 6.4.0#29553
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:deps-eslint
Closed
tools: update eslint to 6.4.0#29553ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:deps-eslint
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:deps-eslint
Conversation
Trott
approved these changes
Sep 14, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I assume you updated this with tools/update-eslint.sh. LGTM if so.
Member
Author
|
@Trott Yep, I just did this by running |
lpinca
approved these changes
Sep 14, 2019
tniessen
approved these changes
Sep 14, 2019
ZYSzys
added
the
author ready
Collaborator
gengjiawen
approved these changes
Sep 16, 2019
JungMinu
approved these changes
Sep 16, 2019
Member
|
Landed in 5de1052 |
Trott
pushed a commit
that referenced
this pull request
Sep 16, 2019
PR-URL: #29553 Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29553 Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29553 Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update eslint to 6.4.0.
Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes