[v12.x] Backport update to V8 7.7 by targos · Pull Request #29241 · nodejs/node

targos · 2019-08-21T08:56:53Z

Shouldn't land before V8 7.7 is stable (around September 10th).

/cc @nodejs/v8-update @addaleax

Here's the current headers diff: https://gist.github.com/ee79b943316ea502a538145531f76dfa

nodejs-github-bot · 2019-08-21T09:02:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25140/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2472/

nodejs-github-bot · 2019-08-21T21:44:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25161/

nodejs-github-bot · 2019-08-22T08:47:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25180/

addaleax · 2019-08-25T15:26:09Z

I think we need to undo the public parts of v8/v8@e423f00, too.

targos · 2019-08-25T17:26:06Z

I was not sur because I saw that the old methods are deprecated and not removed, but I'll check that everything is still here

targos · 2019-08-28T07:37:04Z

@addaleax I checked, and all ResourceConstraints methods are still there.

addaleax · 2019-08-28T11:05:05Z

@targos Yes, but the layout of the fields changed, affecting the class’s size and the way that the inline getters/setters access the fields. And from the research on Workers I know that there are native modules that create new Isolates, so I think we need to keep the class ABI-stable.

targos · 2019-08-28T17:39:46Z

I see. Could you help me a bit on the compatibility patch? I don't really know what to do.

bcoe · 2019-08-30T14:11:32Z

👋 @targos once this lands, could we also backport 8f33053 to 12.x, it should address a fairly significant bug with coverage (I will be confirming this with Node's nightly build ASAP).

nodejs-github-bot · 2019-08-30T16:28:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25303/

addaleax · 2019-08-30T16:29:18Z

Pushed changes to hopefully take care of ResourceConstraints.

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2486/

nodejs-github-bot · 2019-08-31T10:07:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25307/

bnoordhuis · 2019-08-31T11:37:47Z

In v8-inspector.h, the addition of V8StackTrace::buildInspectorObject() changes the vtable and the removal of V8InspectorSession::stateJSON() breaks API. Do we assume that's alright because add-ons aren't expected to use those classes?

targos · 2019-08-31T11:42:54Z

@bnoordhuis the v8-inspector.h header is not exposed by Node.js: #22586

bricss · 2019-09-15T08:49:01Z

Does this backport includes fix from? -> #29472 🤔

PR-URL: nodejs#28016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Update postmortem metadata constants for V8 7.7 in Node.js. PR-URL: nodejs#28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #29241 PR-URL: #28955

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: nodejs#29241 Backport-PR-URL: nodejs#28955 PR-URL: nodejs#28005 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#29241 PR-URL: nodejs#28955

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: nodejs#29241 Backport-PR-URL: nodejs#28955 PR-URL: nodejs#28005 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#29241 PR-URL: nodejs#28955

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #30109 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 Backport-PR-URL: #29241 PR-URL: #28955

Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #30109 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 Backport-PR-URL: #29241 PR-URL: #28955

Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Aug 21, 2019

targos mentioned this pull request Aug 21, 2019

Node.js 12 - V8 version roadmap #25082

Closed

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 21, 2019

targos force-pushed the v8-7.7-v12.x branch from 098328c to 5a90f48 Compare August 28, 2019 07:38

targos mentioned this pull request Aug 30, 2019

deps: patch V8 to 7.7.299.8 #29336

Closed

BridgeAR mentioned this pull request Sep 4, 2019

v12.10.0 proposal #29429

Merged

addaleax mentioned this pull request Sep 7, 2019

stream performance regression 12.6.0 vs 10.16.0 #28586

Closed

targos and others added 6 commits September 17, 2019 11:16

deps: update V8 to 7.7.299.4

e2d7149

build: reset embedder string to "-node.0"

ce858cb

deps: V8: silence irrelevant warning

71cd94c

PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

beevelop mentioned this pull request Sep 26, 2019

2019-09-25 Version 12.11.0 (Current) @BridgeAR beevelop/docker-android-nodejs#335

Closed

targos added a commit that referenced this pull request Oct 8, 2019

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

861a7eb

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

targos added a commit to targos/node that referenced this pull request Oct 25, 2019

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

5245a6b

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

dbb2088

Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request Jan 8, 2020

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

e60dc1d

Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

b335529

Co-authored-by: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

Uh oh!

Conversation

targos commented Aug 21, 2019

Uh oh!

nodejs-github-bot commented Aug 21, 2019 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 21, 2019

Uh oh!

nodejs-github-bot commented Aug 22, 2019

Uh oh!

addaleax commented Aug 25, 2019

Uh oh!

targos commented Aug 25, 2019

Uh oh!

targos commented Aug 28, 2019

Uh oh!

addaleax commented Aug 28, 2019

Uh oh!

targos commented Aug 28, 2019

Uh oh!

bcoe commented Aug 30, 2019

Uh oh!

nodejs-github-bot commented Aug 30, 2019

Uh oh!

addaleax commented Aug 30, 2019

Uh oh!

nodejs-github-bot commented Aug 31, 2019

Uh oh!

bnoordhuis commented Aug 31, 2019

Uh oh!

targos commented Aug 31, 2019

Uh oh!

bricss commented Sep 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Aug 21, 2019 •

edited by targos

Loading

bricss commented Sep 15, 2019 •

edited

Loading