Closed
Conversation
Contributor
|
Missing documentation? |
Member
Author
|
@mscdex I'd like to ask for some feedback on whether this is a valid suggestion before I spend time on docs and tests. |
Member
|
@nodejs/http PTAL |
Member
Author
|
@benjamingr since you approved the |
Member
|
I am really not sure but I am game going on a zoom or chat to understand all the changes you want to make to HTTP at once so I can understand the motivation and make a better decision. |
Member
Author
|
@benjamingr sounds good to me, how do we go about setting that up? |
Member
|
Ping relevant parties and maybe someone from the TSC with access to the zoom? Maybe Matteo (though he probably won't have time in the coming week - probably later) |
Member
Author
|
replaced by #28968 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggestion to add a
completeproperty to http request and response to indicate that no further work can/should be performed on the instance.I believe this is a better alternative to the current
finishedproperty which I believe is currently incorrectly used in a lot of scenarios.Depends on #28621 and #28627 which should probably first be merged.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes