[v8.x] n-api: make func argument of napi_create_threadsafe_function optional#28400
Closed
gabrielschulhof wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x] n-api: make func argument of napi_create_threadsafe_function optional#28400gabrielschulhof wants to merge 1 commit intonodejs:v8.x-stagingfrom
gabrielschulhof wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
nodejs-github-bot
added
c++
gabrielschulhof
changed the title
mhdawson
reviewed
Jun 24, 2019
gabrielschulhof
force-pushed
the
backport-27791-to-v8.x
branch
from
5d69cd4 to
5b1f497
Compare
mhdawson
reviewed
Jun 26, 2019
gabrielschulhof
force-pushed
the
backport-27791-to-v8.x
branch
from
5b1f497 to
64849c3
Compare
richardlau
approved these changes
Jul 1, 2019
BridgeAR
added
the
author ready
Collaborator
Collaborator
Collaborator
Member
|
Removing author ready because IIUC only @nodejs/backporters are supposed to land to 8.x-staging. Feel free to re-add if they are using author ready, but judging by the fact that this hasn't landed after 25 days with author ready applied, I'm guessing they're not. (Which is totally OK!) |
Trott
removed
the
author ready
PR-URL: nodejs#27791 Refs: nodejs#27592 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
gabrielschulhof
force-pushed
the
backport-27791-to-v8.x
branch
from
64849c3 to
d0a05d0
Compare
Contributor
Author
|
Rebased. |
Collaborator
BethGriggs
added
the
semver-minor
Contributor
Author
|
v8.x will receive no further minor versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #27791
Refs: #27592
Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes