vm: increase code coverage of source_text_module.js#28350
Closed
kball wants to merge 2 commits intonodejs:masterfrom
Closed
vm: increase code coverage of source_text_module.js#28350kball wants to merge 2 commits intonodejs:masterfrom
kball wants to merge 2 commits intonodejs:masterfrom
Conversation
addaleax
added
the
esm
addaleax
approved these changes
Jun 21, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
@nodejs/modules-active-members
Co-Authored-By: Anna Henningsen <github@addaleax.net>
Trott
approved these changes
Jun 21, 2019
BridgeAR
approved these changes
Jun 22, 2019
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell
approved these changes
Jul 15, 2019
Collaborator
Member
|
Landed in 99879ca |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
PR-URL: nodejs#28350 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28350 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes