Closed
Conversation
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
the
build
2 tasks
Collaborator
Member
Author
|
This picks up the file being fixed by #28127: Running Markdown linter on docs...
doc/guides/contributing/pull-requests.md
87:1-88:19 warning Use "GitHub" instead of "Github" prohibited-strings remark-lint
⚠ 1 warning |
Trott
approved these changes
Jun 8, 2019
cjihrig
approved these changes
Jun 8, 2019
BridgeAR
approved these changes
Jun 8, 2019
trivikr
approved these changes
Jun 9, 2019
Trott
added
author ready
This comment has been minimized.
This comment has been minimized.
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Member
Author
Member
|
Landed in d74dc17 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 13, 2019
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: nodejs#28128 Refs: nodejs#28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: #28128 Refs: #28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**expansion doesn't behave as expected and as a result files innested subdirectories under
docwere not linted. Usefindinsteadto generate the list of files to lint.
Refs: #28127 (comment)
Blocked until #28127 lands as otherwise the
lint fails on the extra files that are now being picked up.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes