test: missing vtable in test when LTO is enabled

[AdamMajer]

Issue: #28026

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

I’ll try to test it out later today, but maybe it would keep the test working if we don’t implicitly mark the virtual dtor as inline?

diff --git a/test/addons/uv-handle-leak/binding.cc b/test/addons/uv-handle-leak/binding.cc
index 221a12843231..4718ccc9f317 100644
--- a/test/addons/uv-handle-leak/binding.cc
+++ b/test/addons/uv-handle-leak/binding.cc
@@ -15,9 +15,11 @@ void CloseCallback(uv_handle_t* handle) {}
 
 class ExampleOwnerClass {
  public:
-  virtual ~ExampleOwnerClass() {}
+  virtual ~ExampleOwnerClass();
 };
 
+ExampleOwnerClass::~ExampleOwnerClass() {}
+
 ExampleOwnerClass example_instance;
 
 void LeakHandle(const FunctionCallbackInfo<Value>& args) {

[AdamMajer]

@addaleax I'll try that now and will let you know.

[AdamMajer]

Indeed, now it passes with GCC 9.1.1 and LTO. Can you add your change? I'll close this PR as unneeded.

[addaleax]

@AdamMajer Done! #28057