test: switch actual value argument and expected in deepStrictEqual call#27888
Merged
ChALkeR merged 1 commit intonodejs:masterfrom May 27, 2019
Merged
test: switch actual value argument and expected in deepStrictEqual call#27888ChALkeR merged 1 commit intonodejs:masterfrom
ChALkeR merged 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
May 26, 2019
ryzokuken
approved these changes
May 26, 2019
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR.
ryzokuken
added
the
code-and-learn
BridgeAR
approved these changes
May 26, 2019
cjihrig
approved these changes
May 26, 2019
ChALkeR
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
Trott
added
the
author ready
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
Collaborator
Member
|
Please react with 👍for fast-tracking. |
ZYSzys
approved these changes
May 27, 2019
Replace deepStrictEqual call to have actual value as the first argument and the expected value as the second. Change expectedRecvData definition in single place. PR-URL: nodejs#27888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
ChALkeR
force-pushed
the
fix/parallel/http
branch
from
2fb4dfa to
55de6ff
Compare
Member
|
Landed in 55de6ff. Thanks for the contribution! 🎉 https://www.nodetodo.org/next-steps/ is a good list of ideas on possible next steps. (But the next steps are not limited to just that list -- you can always come up with your own)! |
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Replace deepStrictEqual call to have actual value as the first argument and the expected value as the second. Change expectedRecvData definition in single place. PR-URL: #27888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deepStrictEqual call to have actual value as the first argument
and the expected value as the second.
Change expectedRecvData definition in single place.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes