lib: use console.log for TTY on Windows#27829
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
lib: use console.log for TTY on Windows#27829richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
ANSI sequences are emulated on Windows, so use `console.log()` for TTY's on Windows instead of directly writing to the filedescriptor. Fixes: nodejs#27819
Collaborator
2 tasks
cjihrig
approved these changes
May 22, 2019
Collaborator
Contributor
|
Since the original point of this change was to avoid using |
Member
|
I mean … I think I’d prefer #27823 and sticking with |
Contributor
|
I would prefer the revert as well, but based on #27819 (comment), it seemed like this would be revisited again anyway. If we're going to stick with the revert, then let's go that route. |
Member
Author
|
Let's go with the revert then 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANSI sequences are emulated on Windows, so use
console.log()forTTY's on Windows instead of directly writing to the filedescriptor.
Fixes: #27819
This is an alternative to #27823,
which is a full revert.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes