test: add mustCallAtLeast to test-fs-read-stream-fd test#27461
Closed
hardfist wants to merge 1 commit intonodejs:masterfrom
Closed
test: add mustCallAtLeast to test-fs-read-stream-fd test#27461hardfist wants to merge 1 commit intonodejs:masterfrom
hardfist wants to merge 1 commit intonodejs:masterfrom
Conversation
oyyd
added
the
code-and-learn
starkwang
approved these changes
Apr 28, 2019
Change-Id: Ib74392326ee7471732488c1cf3c32f08685e0439
yorkie
approved these changes
Apr 28, 2019
ZYSzys
approved these changes
Apr 28, 2019
cjihrig
approved these changes
Apr 28, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
This change isn't necessary, but LGTM.
ZYSzys
added
the
author ready
Collaborator
Contributor
|
please leave 👍 to fast track |
antsmartian
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
ZYSzys
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #27461 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 4cf8b42 🎉. Congratulation for your first contribution to Node.js. You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute. |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #27461 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From code and learn: nodejs/code-and-learn#94
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes