src: fix warning on mismatched fn signature#26950
Closed
sam-github wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix warning on mismatched fn signature#26950sam-github wants to merge 1 commit intonodejs:masterfrom
sam-github wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
@sam-github Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
c++
Collaborator
addaleax
approved these changes
Mar 27, 2019
richardlau
approved these changes
Mar 27, 2019
tniessen
approved these changes
Mar 27, 2019
ZYSzys
approved these changes
Mar 28, 2019
BridgeAR
added
the
author ready
Add the missing `void* priv` to node_report's Initialize().
sam-github
force-pushed
the
fix-node-report-missing-priv
branch
from
792ceef to
949fff5
Compare
Collaborator
Member
Collaborator
Contributor
|
Landed in 66b9536. |
danbev
pushed a commit
that referenced
this pull request
Apr 1, 2019
Add the missing `void* priv` to node_report's Initialize(). PR-URL: #26950 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Add the missing `void* priv` to node_report's Initialize(). PR-URL: #26950 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Add the missing `void* priv` to node_report's Initialize(). PR-URL: #26950 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Add the missing `void* priv` to node_report's Initialize(). PR-URL: #26950 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing
void* privto node_report's Initialize().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes