test: refactor test-*-ci-reneg-attack.js#25660
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Refactor test-tls-ci-reneg-attack: * Use port 0 (OS-assigned available port) rather than common.PORT * Remove unnecessary boolean that causes race condition failure on some operating systems Refactor that test and test-https-ci-reneg-attack: * Check all stderr, not just the chunk coming in now, in case it breaks up chunks in the middle of where the regexps are supposed to match.
2 tasks
apapirovski
approved these changes
Jan 25, 2019
Trott
added
the
author ready
Member
Author
|
Pummel tests are not run in CI, so lite CI should be sufficient. Might run a full pummel test suite if we get the pummel tests fixed (in other PRs)... |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test-tls-ci-reneg-attack:
operating systems
Refactor that test and test-https-ci-reneg-attack:
up chunks in the middle of where the regexps are supposed to match.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes