src: mitigate MSVC dynamic initialization bug

[refack]

Fixes: #25593
Refs: https://developercommunity.visualstudio.com/content/problem/432157/dynamic-initializers-out-of-order.html

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2306/pipeline

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/20217/

[addaleax]

The change LGTM, but as @seishun says in the other thread – it shouldn’t do anything at all? Along the lines of #25593 (comment): This shouldn’t be an issue when the definitions are all in one file, and it’s likely that something else is going on here…

[seishun]

Let's not make magical workarounds. We should figure out why this is happening and (most likely) submit a bug report to Visual Studio.

[refack]

I agree this is "magical". AFAICR that is why I didn't submit a PR with this till now.
But, it fixes the problem at hand so ¯\(ツ)/¯

[seishun]

If the underlying issue in the compiler is not fixed then it might break in another way in the next version.

[bzoz]

Until we get new VS with the bug fixed, we need to do something to make Node work again.

[seishun]

we need to do something to make Node work again

FYI it works - just not the debug build.

[seishun]

In any case, the commit message should explain what the problem is and how it's being mitigated.

[seishun]

The problem is now "Under Investigation" so maybe it will be fixed very soon.

[addaleax]

@refack I think with an updated commit message this should be ready to go 👍

(And I’m assuming we want to merge this even if it gets fixed in the compiler itself)

[seishun]

(And I’m assuming we want to merge this even if it gets fixed in the compiler itself)

I don't think so - I find it slightly more readable when an instance definition follows the class definition.

[refack]

I've tested master with the VS2019 preview (CL.EXE version 19.20.27027.1), and it seems like the compiler issue does not reproduce...
But IMO this PR is low impact enough to meanwhile be a beneficial workaround (Node 10 & 11 are built with VS2017).

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/20292/
Resume: https://ci.nodejs.org/job/node-test-pull-request/20294/
Resume: https://ci.nodejs.org/job/node-test-pull-request/20469/
Resume: https://ci.nodejs.org/job/node-test-commit/25475/