Skip to content

deps: cherry-pick c736883 from upstream V8#25430

Closed
hashseed wants to merge 2 commits intonodejs:masterfrom
hashseed:halfsiphash
Closed

deps: cherry-pick c736883 from upstream V8#25430
hashseed wants to merge 2 commits intonodejs:masterfrom
hashseed:halfsiphash

Conversation

@hashseed
Copy link
Member

@hashseed hashseed commented Jan 10, 2019

Original commit message:

Optionally use halfsiphash for integer hashing.

Change-Id: Ibd14f7b3fe78635675c76ae864112e3a3a7bc701
Reviewed-on: https://chromium-review.googlesource.com/c/1382463
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58674}

Refs: v8/v8@c736883
Refs: #23259

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@hashseed
deps: cherry-pick c736883 from upstream V8
abf437b 
Original commit message:

    Optionally use halfsiphash for integer hashing.

    Change-Id: Ibd14f7b3fe78635675c76ae864112e3a3a7bc701
    Reviewed-on: https://chromium-review.googlesource.com/c/1382463
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#58674}

Refs: v8/v8@c736883
@hashseed hashseed requested review from ofrobots and targos January 10, 2019 11:44
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 10, 2019

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2219/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jan 10, 2019
mhdawson
mhdawson approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

ofrobots
ofrobots approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM.

@hashseed
Copy link
Member Author

hashseed commented Jan 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20099/

This was referenced Jan 16, 2019
Closed
Closed
@hashseed
Copy link
Member Author

hashseed commented Jan 21, 2019

Umm... trying again: https://ci.nodejs.org/job/node-test-pull-request/20224/

@hashseed
Copy link
Member Author

hashseed commented Feb 1, 2019

Landed in 7c8ac5a

@hashseed hashseed closed this Feb 4, 2019
@hashseed hashseed deleted the halfsiphash branch February 4, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson mhdawson approved these changes

@targos targos Awaiting requested review from targos

+1 more reviewer

@ofrobots ofrobots ofrobots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hashseed @nodejs-github-bot @ofrobots @jasnell @mhdawson