vm: reuse validateString of internal/validators#25074
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:validate-string-vm
Closed
vm: reuse validateString of internal/validators#25074ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:validate-string-vm
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:validate-string-vm
Conversation
targos
approved these changes
Dec 16, 2018
Contributor
lpinca
approved these changes
Dec 16, 2018
jasnell
approved these changes
Dec 17, 2018
watilde
approved these changes
Dec 17, 2018
Contributor
|
Landed in e5966ef. |
danbev
pushed a commit
that referenced
this pull request
Dec 20, 2018
PR-URL: #25074 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
PR-URL: #25074 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #25074 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25074 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validateStringfunction invm.jsis just one more judgement which validates whetherprop !== undefinedthan thevalidateStringfunction ininternal/validators:node/lib/vm.js
Lines 153 to 156 in 8f4b924
node/lib/internal/validators.js
Lines 123 to 126 in 8f4b924
So now just reuse the general
validateStringinvalidator.jstotally.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes