doc: fix index in table of contents in BUILDING.md#23777
Closed
ZYSzys wants to merge 2 commits intonodejs:masterfrom
zys-contrib:building
Closed
doc: fix index in table of contents in BUILDING.md#23777ZYSzys wants to merge 2 commits intonodejs:masterfrom zys-contrib:building
ZYSzys wants to merge 2 commits intonodejs:masterfrom
zys-contrib:building
Conversation
nodejs-github-bot
added
build
Member
Trott
approved these changes
Oct 20, 2018
vsemozhetbyt
approved these changes
Oct 20, 2018
vsemozhetbyt
added
the
author ready
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
|
Maybe you could fix one more nit that slipped in the same PR: add a missing colon after this sentence: If you want to check the other options, please refer to the help by using
the `--help` option |
Member
Author
|
@vsemozhetbyt Fixed. So seems that we need to resume CI again ? |
Member
vsemozhetbyt
added
the
fast-track
Contributor
|
Landed in 3e3ce22 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Oct 20, 2018
Also, a missing colon was added. PR-URL: #23777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
Also, a missing colon was added. PR-URL: #23777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixs the indexing in table of contents in BUILDING.md which was changed by #23490
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes