doc: document use of buffer.swap16() for utf16be#23747
Closed
jasnell wants to merge 5 commits intonodejs:masterfrom
Closed
doc: document use of buffer.swap16() for utf16be#23747jasnell wants to merge 5 commits intonodejs:masterfrom
jasnell wants to merge 5 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
buffer
Trott
reviewed
Oct 19, 2018
doc/api/buffer.md
Outdated
| // Throws ERR_INVALID_BUFFER_SIZE | ||
| ``` | ||
|
|
||
| One convenient use of `buf.swap16()` is to perform a fast *in-place* conversion |
lpinca
approved these changes
Oct 19, 2018
vsemozhetbyt
approved these changes
Oct 19, 2018
BridgeAR
approved these changes
Oct 19, 2018
Co-Authored-By: jasnell <[email protected]>
Co-Authored-By: jasnell <[email protected]>
Co-Authored-By: jasnell <[email protected]>
jasnell
commented
Oct 19, 2018
Member
Author
|
Please 👍 to fast-track |
jasnell
added a commit
that referenced
this pull request
Oct 19, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
Author
|
Landed in ad61550 |
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell
added a commit
that referenced
this pull request
Oct 21, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Fixes: #12813 PR-URL: #23747 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12813
Checklist