Skip to content

doc: add Ruben Bridgewater to release team#23432

Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:add-myself-to-release-team
Closed

doc: add Ruben Bridgewater to release team#23432
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:add-myself-to-release-team

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Oct 11, 2018

/cc @nodejs/release @nodejs/tsc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2018

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1208/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 11, 2018
@targos
Copy link
Member

targos commented Oct 11, 2018

@nodejs/build-infra Ruben needs his ssh keys added to the dist user on the website host.

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Oct 12, 2018
MylesBorins
MylesBorins suggested changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the current governance of the Release team this should not land until Ruben has prepared 3 Current releases.

If we are concerned that the timeline for this is too long we can revisit those rules over in the Release repo

@targos
Copy link
Member

targos commented Nov 20, 2018

Ruben prepared the release of v11.2.0 last week. Per the new governance, he shall be considered a full member of the releasers team now. @MylesBorins can we proceed with this PR?

MylesBorins
MylesBorins approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Nov 20, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1657/

mhdawson
mhdawson approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Nov 20, 2018

@BridgeAR could you rebase on master? I tried to set the option in the CI job but it failed.

@BridgeAR BridgeAR force-pushed the add-myself-to-release-team branch from 5b3af3d to ad4890c Compare November 21, 2018 06:37
@BridgeAR
Copy link
Member Author

BridgeAR commented Nov 21, 2018

@targos done

CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1663/

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 21, 2018

Welcome to the team!

landed in 9379ab3

MylesBorins pushed a commit that referenced this pull request Nov 21, 2018
@BridgeAR @MylesBorins
doc: add Ruben Bridgewater to release team
9379ab3 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Nov 21, 2018
Merged
Closed
targos pushed a commit that referenced this pull request Nov 21, 2018
@BridgeAR @targos
doc: add Ruben Bridgewater to release team
5101ab8 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@BridgeAR @rvagg
doc: add Ruben Bridgewater to release team
1a74fad 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
@beevelop beevelop mentioned this pull request Dec 7, 2018
Closed
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@BridgeAR @codebytere
doc: add Ruben Bridgewater to release team
b0d265c 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
doc: add Ruben Bridgewater to release team
7ab43c5 
PR-URL: nodejs#23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@BridgeAR @codebytere
doc: add Ruben Bridgewater to release team
f0602f8 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the add-myself-to-release-team branch January 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

+3 more reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@evanlucas evanlucas evanlucas approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.