test: error when empty buffer is passed to filehandle.read()#23250
Closed
shisama wants to merge 3 commits intonodejs:masterfrom
Closed
test: error when empty buffer is passed to filehandle.read()#23250shisama wants to merge 3 commits intonodejs:masterfrom
shisama wants to merge 3 commits intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Oct 4, 2018
thefourtheye
reviewed
Oct 4, 2018
Contributor
There was a problem hiding this comment.
Nit: if we could write this with await it would look better.
thefourtheye
reviewed
Oct 4, 2018
Contributor
There was a problem hiding this comment.
Also, now that you are doing it, please cover the fs promises read with a file descriptor.
BridgeAR
approved these changes
Oct 4, 2018
jasnell
approved these changes
Oct 5, 2018
thefourtheye
approved these changes
Oct 6, 2018
Contributor
There was a problem hiding this comment.
Nit: I think this needs to be aligned with 'The argument...
shisama
force-pushed
the
test-fsPromises-readfile-empty-buffer
branch
from
61d6bef to
a93f6e0
Compare
trivikr
approved these changes
Oct 6, 2018
shisama
force-pushed
the
test-fsPromises-readfile-empty-buffer
branch
from
a93f6e0 to
3b01a5e
Compare
Contributor
Author
|
@danbev Thank you for your comment. I updated the commit message. |
Contributor
added 3 commits
October 10, 2018 18:10
Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage.
shisama
force-pushed
the
test-fsPromises-readfile-empty-buffer
branch
from
3b01a5e to
41afe00
Compare
Contributor
|
Re-run of failing node-test-commit-linux-containered ✔️ |
Contributor
Author
|
@danbev Thank you to tell me that this should be rebased and to run CI. |
Contributor
|
Landed in a8530bc. |
danbev
pushed a commit
that referenced
this pull request
Oct 10, 2018
Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. PR-URL: #23250 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. PR-URL: #23250 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to occur error when empty buffer is passed to
filehandle.read()to increase coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes