docs: replace 1 by process.stdout.fd#22564
Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
async_hooks
vsemozhetbyt
approved these changes
Aug 28, 2018
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
addaleax
approved these changes
Aug 28, 2018
Fishrock123
approved these changes
Aug 28, 2018
lpinca
approved these changes
Aug 28, 2018
Contributor
Author
|
CI before landing: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/719/ |
Contributor
Author
|
Landed in 2584052 |
starkwang
added a commit
that referenced
this pull request
Aug 29, 2018
PR-URL: #22564 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 29, 2018
PR-URL: #22564 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22564 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22564 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
fs.writeSync(1, ...)is a little bit confusing in our docs, especially for those users who are not familiar with Unix File System. Replace the number1it by a constantprocess.stdout.fdseems more clear.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes