build: do not lint fixtures in make lint-md#22549
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
build: do not lint fixtures in make lint-md#22549joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
danbev
approved these changes
Aug 27, 2018
jasnell
approved these changes
Aug 27, 2018
Member
|
I would prefer no changes to line 1093 and adding |
BridgeAR
approved these changes
Aug 31, 2018
BridgeAR
added
the
author ready
addaleax
removed
the
author ready
Member
|
Removing |
Member
|
Ping @joyeecheung |
joyeecheung
force-pushed
the
lint-skip-fixtures
branch
from
68cf249 to
672474f
Compare
Member
Author
|
Updated to use the |
Trott
approved these changes
Sep 15, 2018
Member
|
Everything is good on CI except a known Windows flake. Windows re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20733/ (Update: ✔️) |
refack
approved these changes
Sep 15, 2018
refack
added
the
author ready
Contributor
|
Resume CI (with a special Windows trick): https://ci.nodejs.org/job/node-test-commit/21481/ |
Member
Author
|
Windows is still pretty red.. |
Contributor
Member
|
Only red was Windows fanned. Known flaky. Here's a re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20753/ |
Member
Member
Author
|
Windows build is (finally) green |
Member
Author
|
Landed in bb9d788, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Sep 17, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 18, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #22549 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful if we need to put markdown files in
test/fixtures(I was working on pulling the WPT there)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes